Bug 98080

Summary: Address a FIXME in JSArray::sort
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, bfulgham, ggaren, mhahnenberg, msaboff, oliver, sam, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=97603
Attachments:
Description Flags
the patch oliver: review+

Description Filip Pizlo 2012-10-01 15:18:57 PDT
And get rid of fast sorting of sparse maps.  Patch forthcoming.
Comment 1 Filip Pizlo 2012-10-01 15:37:12 PDT
Created attachment 166560 [details]
the patch
Comment 2 WebKit Review Bot 2012-10-01 15:38:59 PDT
Attachment 166560 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/runtime/JSArray.cpp:873:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2012-10-01 18:05:37 PDT
Landed in http://trac.webkit.org/changeset/130102
Comment 4 Brent Fulgham 2017-04-13 08:47:46 PDT
<rdar://problem/12407844>