Bug 98076

Summary:

baseline flexitem aligment in columns incorrect when writing mode is orthogonal

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

Layout and Rendering

Assignee:

KyungTae Kim <ktf.kim>

Status:

NEW ---

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, hyatt, jonlee, ktf.kim, mitz, rniwa, webkit-bug-importer, webkit

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://plexode.com/u/#AH)5(v42G%22E9(!flex686%2F27%3A26%3Cr5!writing-mode7r4ertical-rlG%3EE*%3E%0Ab)(style%3DG2(%20M!-webkit-~http://plexode.com/eval3/#ht=6div)display79%3B9-flow7(column%3B(!item-align7(baselineG*((6h1Hhello8h1*((6pHworld8p*8div*

Bug Depends on:

Bug Blocks:

62048

Attachments:

Description	Flags
Patch	beidson: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none

Description Tony Chang 2012-10-01 14:53:57 PDT

Test case in URL.

We try to compute the ascent of the vertical text, but we get -1 because firstLineBoxBaseline returns -1 when we're at a writing mode root.  For flexbox, we actually want the baseline even in the orthogonal case.

Comment 1 KyungTae Kim 2013-04-22 04:10:30 PDT

Is there a plan for fixing this bug?
I made a patch for fixing this. Can I upload that patch on here?

Comment 2 KyungTae Kim 2013-05-06 04:03:31 PDT

Created attachment 200651 [details]
Patch

Comment 3 Build Bot 2013-05-06 05:11:33 PDT

Comment on attachment 200651 [details]
Patch

Attachment 200651 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/300061

New failing tests:
css3/flexbox/flex-align-orthogonal-writing-mode.html

Comment 4 Build Bot 2013-05-06 05:11:34 PDT

Created attachment 200660 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

Comment 5 Build Bot 2013-05-06 06:07:09 PDT

Comment on attachment 200651 [details]
Patch

Attachment 200651 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/336053

New failing tests:
css3/flexbox/flex-align-orthogonal-writing-mode.html

Comment 6 Build Bot 2013-05-06 06:07:12 PDT

Created attachment 200663 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

Comment 7 Build Bot 2013-05-06 06:51:13 PDT

Comment on attachment 200651 [details]
Patch

Attachment 200651 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/340026

New failing tests:
css3/flexbox/flex-align-orthogonal-writing-mode.html

Comment 8 Build Bot 2013-05-06 06:51:15 PDT

Created attachment 200665 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

Comment 9 Brady Eidson 2016-05-24 21:38:18 PDT

Comment on attachment 200651 [details]
Patch

r- to clear stale patches from the review queue

Comment 10 Jon Lee 2016-12-15 16:26:27 PST

<rdar://problem/29695096>

Comment 11 Elliot 2022-09-03 10:33:56 PDT

Are there any updates on this issue? Most other major browser engines support baseline alignment now in 2022. Having this implemented would allow the property to be used appropriately.