Bug 98074

Summary:

Update main frame scroll position immediately for programmatic scrolls

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, beidson, jamesr, simon.fraser, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

97287

Attachments:

Description	Flags
patch	simon.fraser: review+

Tim Horton

Reported 2012-10-01 14:46:10 PDT

http://trac.webkit.org/changeset/115681 disabled this because it caused brokenness with user scrolls, however, we should be able to immediately commit programmatic scrolls. This will aid in running the layout tests with tiled drawing on, as many of the tests depend on the scroll position being updated immediately after a scrollTo or scrollBy.

Attachments
patch (2.72 KB, patch) 2012-10-01 14:50 PDT, Tim Horton	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2012-10-01 14:50:43 PDT

Created attachment 166551 [details] patch

Beth Dakin

Comment 2 2012-10-02 12:14:13 PDT

I'm wondering if this patch makes this code that Brady added recently totally unnecessary: http://trac.webkit.org/changeset/129652

Simon Fraser (smfr)

Comment 3 2012-10-23 20:40:03 PDT

It might do, yes.

Simon Fraser (smfr)

Comment 4 2012-10-23 20:40:28 PDT

We need this change to make scrollTo() followed by layerTreeAsText() do the right thing in tests.

Tim Horton

Comment 5 2012-10-24 16:37:39 PDT

I'm going to land this, then investigate rolling out Brady's change if we don't need it anymore.

Tim Horton

Comment 6 2012-10-24 16:41:37 PDT

(In reply to comment #5) > I'm going to land this, then investigate rolling out Brady's change if we don't need it anymore. Ergh, I didn't update the changelog after merging the change. Oh, well. http://trac.webkit.org/changeset/132422

Tim Horton

Comment 7 2012-10-25 15:10:00 PDT

http://trac.webkit.org/changeset/115681 should have been warning enough... this broke the Find overlay again :\

Note You need to log in before you can comment on or make changes to this bug.