Bug 98058

Summary: Consolidate more MutationObserverRegistration logic in Node
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, rafaelw, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Klein
Reported 2012-10-01 11:59:51 PDT
Consolidate more MutationObserverRegistration logic in Node
Attachments
Patch (7.78 KB, patch)
2012-10-01 12:06 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.69 KB, patch)
2012-10-01 12:31 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-10-01 12:06:55 PDT
Created attachment 166520 [details] Patch
Ryosuke Niwa
Comment 2 2012-10-01 12:12:23 PDT
Comment on attachment 166520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166520&action=review > Source/WebCore/ChangeLog:12 > + This patch inverts that behavior so that there's no need to return the I like it better without "inverts that behavior". It confused me.
Ryosuke Niwa
Comment 3 2012-10-01 12:13:22 PDT
Comment on attachment 166520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166520&action=review > Source/WebCore/dom/Node.cpp:2484 > Vector<OwnPtr<MutationObserverRegistration> >* registry = ensureRareData()->ensureMutationObserverRegistry(); On a completely unrelated note, we need to invent a variant of HashMap that behaves like Vector when the map is small.
Adam Klein
Comment 4 2012-10-01 12:31:48 PDT
Created attachment 166527 [details] Patch for landing
Adam Klein
Comment 5 2012-10-01 12:32:17 PDT
Comment on attachment 166520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166520&action=review >> Source/WebCore/dom/Node.cpp:2484 >> Vector<OwnPtr<MutationObserverRegistration> >* registry = ensureRareData()->ensureMutationObserverRegistry(); > > On a completely unrelated note, we need to invent a variant of HashMap that behaves like Vector when the map is small. Definitely, there are several places recently where I've wanted something like that.
WebKit Review Bot
Comment 6 2012-10-01 13:11:54 PDT
Comment on attachment 166527 [details] Patch for landing Clearing flags on attachment: 166527 Committed r130069: <http://trac.webkit.org/changeset/130069>
WebKit Review Bot
Comment 7 2012-10-01 13:11:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.