Bug 98052

Summary: [BlackBerry] Add a early return in buildCMakeProjectOrExit()
Product: WebKit Reporter: Ming Xie <mxie>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ming Xie
Reported 2012-10-01 11:32:08 PDT
We would like to have an option to separate the CMake configure and build to two steps.
Attachments
Patch (1.41 KB, patch)
2012-10-01 11:41 PDT, Ming Xie 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2012-10-01 11:48 PDT, Ming Xie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ming Xie
Comment 1 2012-10-01 11:41:17 PDT
Created attachment 166513 [details] Patch
WebKit Review Bot
Comment 2 2012-10-01 11:42:54 PDT
Attachment 166513 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitdi..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ming Xie
Comment 3 2012-10-01 11:48:59 PDT
Created attachment 166515 [details] Patch
Rob Buis
Comment 4 2012-10-01 11:50:02 PDT
Comment on attachment 166515 [details] Patch LGTM.
WebKit Review Bot
Comment 5 2012-10-01 12:12:34 PDT
Comment on attachment 166515 [details] Patch Rejecting attachment 166515 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [chromium] ASSERT that the embedder has set a default locale When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14124035
WebKit Review Bot
Comment 6 2012-10-01 12:23:36 PDT
Comment on attachment 166515 [details] Patch Clearing flags on attachment: 166515 Committed r130066: <http://trac.webkit.org/changeset/130066>
WebKit Review Bot
Comment 7 2012-10-01 12:23:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.