Bug 98052 - [BlackBerry] Add a early return in buildCMakeProjectOrExit()
Summary: [BlackBerry] Add a early return in buildCMakeProjectOrExit()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 11:32 PDT by Ming Xie
Modified: 2012-10-01 12:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2012-10-01 11:41 PDT, Ming Xie 		no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2012-10-01 11:48 PDT, Ming Xie 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Xie 2012-10-01 11:32:08 PDT 
We would like to have an option to separate the CMake configure and build to two steps.
Comment 1 Ming Xie 2012-10-01 11:41:17 PDT 
Created attachment 166513 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-01 11:42:54 PDT 
Attachment 166513 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitdi..." exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ming Xie 2012-10-01 11:48:59 PDT 
Created attachment 166515 [details]
Patch
Comment 4 Rob Buis 2012-10-01 11:50:02 PDT 
Comment on attachment 166515 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-10-01 12:12:34 PDT 
Comment on attachment 166515 [details]
Patch

Rejecting attachment 166515 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [chromium] ASSERT that the embedder has set a default locale

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/14124035
Comment 6 WebKit Review Bot 2012-10-01 12:23:36 PDT 
Comment on attachment 166515 [details]
Patch

Clearing flags on attachment: 166515

Committed r130066: <http://trac.webkit.org/changeset/130066>
Comment 7 WebKit Review Bot 2012-10-01 12:23:39 PDT 
All reviewed patches have been landed.  Closing bug.