Bug 98044

Summary: Enable ENCRYPTED_MEDIA support on Mac.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, dglazkov, eric.carlson, feature-media-reviews, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98090    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch andersca: review+

Jer Noble
Reported 2012-10-01 09:50:16 PDT
Enable ENCRYPTED_MEDIA support on Mac.
Attachments
Patch (37.54 KB, patch)
2012-10-01 10:14 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (37.58 KB, patch)
2012-10-01 11:18 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (50.11 KB, patch)
2012-10-05 16:21 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (62.94 KB, patch)
2012-10-10 17:42 PDT, Jer Noble 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-10-01 10:14:47 PDT
Created attachment 166497 [details] Patch
Build Bot
Comment 2 2012-10-01 10:57:31 PDT
Comment on attachment 166497 [details] Patch Attachment 166497 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14086859
Jer Noble
Comment 3 2012-10-01 11:18:29 PDT
Created attachment 166509 [details] Patch Wrap MediaPlayerPrivateAVFoundationObjC::extendedSupportsType() in #if ENABLE(ENCRYPTED_MEDIA).
WebKit Review Bot
Comment 4 2012-10-01 14:53:08 PDT
Comment on attachment 166509 [details] Patch Attachment 166509 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14080988 New failing tests: fast/events/constructors/media-key-event-constructor.html
Jer Noble
Comment 5 2012-10-05 16:21:14 PDT
Created attachment 167408 [details] Patch Add expected results for the mac platform.
WebKit Review Bot
Comment 6 2012-10-05 18:24:43 PDT
Comment on attachment 167408 [details] Patch Attachment 167408 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14168943 New failing tests: fast/events/constructors/media-key-event-constructor.html
Jer Noble
Comment 7 2012-10-10 17:42:39 PDT
Created attachment 168105 [details] Patch Copied generic expected results to chplatform/chromium due to chromium results search order.
Anders Carlsson
Comment 8 2012-10-11 15:44:19 PDT
Comment on attachment 168105 [details] Patch Id -> ID everywhere. Looks great otherwise!
Jer Noble
Comment 9 2012-10-12 10:48:38 PDT
Unfortunately "sessionId" with its capitalization is part of the spec, so there's not much that can be done there. However, all the other instances of Id will be changed to ID. Thanks!
Jer Noble
Comment 10 2012-10-12 11:08:37 PDT
Committed r131201: <http://trac.webkit.org/changeset/131201>
Note You need to log in before you can comment on or make changes to this bug.