Bug 98039

Summary: [webkitpy] Detect the multiple names of the wdiff binary in the Port class.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, gustavo, mrobinson, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Raphael Kubo da Costa (:rakuco)
Reported 2012-10-01 09:06:02 PDT
[webkitpy] Detect the multiple names of the wdiff binary in the Port class.
Attachments
Patch (3.28 KB, patch)
2012-10-01 09:24 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.17 KB, patch)
2012-10-01 12:19 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-10-01 09:24:10 PDT
Created attachment 166491 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-10-01 09:27:19 PDT
Comment on attachment 166491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166491&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:1234 > + for path in ("/usr/bin/wdiff", "/usr/bin/dwdiff"): Ideally, we should just check for 'wdiff' and 'dwdiff' to be able to also remove the implementation in chromium_mac.py, but I couldn't think of a portable way of getting a full path from that.
Dirk Pranke
Comment 3 2012-10-01 11:28:50 PDT
Comment on attachment 166491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166491&action=review >> Tools/Scripts/webkitpy/layout_tests/port/base.py:1234 >> + for path in ("/usr/bin/wdiff", "/usr/bin/dwdiff"): > > Ideally, we should just check for 'wdiff' and 'dwdiff' to be able to also remove the implementation in chromium_mac.py, but I couldn't think of a portable way of getting a full path from that. perhaps we should have an is_in_the_path() abstraction somewhere that we can reuse for things like this ...
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-10-01 12:19:33 PDT
Created attachment 166522 [details] Patch for landing
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-10-01 12:22:11 PDT
Committed r130065: <http://trac.webkit.org/changeset/130065>
Note You need to log in before you can comment on or make changes to this bug.