| Summary: | [webkitpy] Detect the multiple names of the wdiff binary in the Port class. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||
| Component: | Tools / Tests | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dpranke, gustavo, mrobinson, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Raphael Kubo da Costa (:rakuco)
2012-10-01 09:06:02 PDT
Created attachment 166491 [details]
Patch
Comment on attachment 166491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166491&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:1234 > + for path in ("/usr/bin/wdiff", "/usr/bin/dwdiff"): Ideally, we should just check for 'wdiff' and 'dwdiff' to be able to also remove the implementation in chromium_mac.py, but I couldn't think of a portable way of getting a full path from that. Comment on attachment 166491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166491&action=review >> Tools/Scripts/webkitpy/layout_tests/port/base.py:1234 >> + for path in ("/usr/bin/wdiff", "/usr/bin/dwdiff"): > > Ideally, we should just check for 'wdiff' and 'dwdiff' to be able to also remove the implementation in chromium_mac.py, but I couldn't think of a portable way of getting a full path from that. perhaps we should have an is_in_the_path() abstraction somewhere that we can reuse for things like this ... Created attachment 166522 [details]
Patch for landing
Committed r130065: <http://trac.webkit.org/changeset/130065> |