Bug 98014

Summary: Make wait-for-SVN-server.py accept empty string as revision
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, galpeter, hausmann, ossy, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85887    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-10-01 04:22:40 PDT
Force build on build.webkit.org passes empty string as revision to wait-for-SVN-server.py, but it accepts only int revision numbers.
Attachments
Patch (2.11 KB, patch)
2012-11-06 07:34 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-10-01 04:24:56 PDT
Of course it is possible to make buildmaster not to pass '-r ""' if revision property is empty string ... I'll check this way too. (but it needs fix in master.cfg and buildmaster restart)
Csaba Osztrogonác
Comment 2 2012-11-06 07:34:47 PST
Created attachment 172584 [details] Patch
Peter Gal
Comment 3 2012-11-06 07:38:27 PST
lgtm. still, is this a valid usecase?
Peter Gal
Comment 4 2012-11-06 07:38:55 PST
(In reply to comment #3) > lgtm. still, is this a valid usecase? ahh sorry. missed the previous comments.
Csaba Osztrogonác
Comment 5 2012-11-07 23:29:34 PST
Comment on attachment 172584 [details] Patch Clearing flags on attachment: 172584 Committed r133854: <http://trac.webkit.org/changeset/133854>
Csaba Osztrogonác
Comment 6 2012-11-07 23:29:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.