Bug 98014 - Make wait-for-SVN-server.py accept empty string as revision
Summary: Make wait-for-SVN-server.py accept empty string as revision
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on: 85887
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-01 04:22 PDT by Csaba Osztrogonác
Modified: 2012-11-07 23:29 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2012-11-06 07:34 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-10-01 04:22:40 PDT 
Force build on build.webkit.org passes empty string as revision
to wait-for-SVN-server.py, but it accepts only int revision numbers.
Comment 1 Csaba Osztrogonác 2012-10-01 04:24:56 PDT 
Of course it is possible to make buildmaster not to pass '-r ""' if 
revision property is empty string ... I'll check this way too. 
(but it needs fix in master.cfg and buildmaster restart)
Comment 2 Csaba Osztrogonác 2012-11-06 07:34:47 PST 
Created attachment 172584 [details]
Patch
Comment 3 Peter Gal 2012-11-06 07:38:27 PST 
lgtm. still, is this a valid usecase?
Comment 4 Peter Gal 2012-11-06 07:38:55 PST 
(In reply to comment #3)
> lgtm. still, is this a valid usecase?

ahh sorry. missed the previous comments.
Comment 5 Csaba Osztrogonác 2012-11-07 23:29:34 PST 
Comment on attachment 172584 [details]
Patch

Clearing flags on attachment: 172584

Committed r133854: <http://trac.webkit.org/changeset/133854>
Comment 6 Csaba Osztrogonác 2012-11-07 23:29:39 PST 
All reviewed patches have been landed.  Closing bug.