Bug 98013
| Summary: | Fix SVN mirror handling for the first build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ossy |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 85887 | ||
| Bug Blocks: | |||
Csaba Osztrogonác
The "wating for SVN server" buildstep runs before the SVN buildstep.
( It is correct, because Tools/BuildSlaveSupport/wait-for-SVN-server.py
is to wait until the SVN mirror is in sync with svn.webkit.org. )
But unfortunately we can't run Tools/BuildSlaveSupport/wait-for-SVN-server.py
after a broken svn buildtep or for the first build of a new master, because
Tools/BuildSlaveSupport/wait-for-SVN-server.py doesn't exist at all.
We can solve this problem with downloading wait-for-SVN-server.py before running it:
curl https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/wait-for-SVN-server.py?format=txt -o Tools/BuildSlaveSupport/wait-for-SVN-server.py --create-dirs
It isn't the best fix ... Downloading this script always is absolutely unnecessary.
But checking the existance of this file from master.cfg isn't trivial.
process.buildstep.BuildStep.FileExists does a similar thing, but it isn't good for us:
http://buildbot.net/buildbot/docs/0.8.5/reference/buildbot.steps.slave.FileExists-class.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
Fixed by https://trac.webkit.org/changeset/163372
and https://trac.webkit.org/changeset/163441