Bug 97963

Summary: AsyncFileSystem::openFileSystem should have FileSystemType as a parameter.
Product: WebKit Reporter: Dongwoo Joshua Im (dwim) <dw.im>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, gyuyoung.kim, mifenton, rwlbuis, tzik, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 91187    
Attachments:
Description Flags
patch none

Dongwoo Joshua Im (dwim)
Reported 2012-09-29 00:19:09 PDT
I totally believe AsyncFileSystem::openFileSystem should have FileSystemType as a parameter. FileSystemType is an important information to maintain the file system itself. And, there is "FIXME" in the AsyncFileSystem.cpp, as well. : // FIXME: Add FileSystemType parameter. I'll upload patch soon.
Attachments
patch (7.72 KB, patch)
2012-09-29 00:49 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongwoo Joshua Im (dwim)
Comment 1 2012-09-29 00:49:38 PDT
Created attachment 166354 [details] patch
Gyuyoung Kim
Comment 2 2012-09-29 05:34:40 PDT
Comment on attachment 166354 [details] patch Looks good to me. Any other opinion in this patch ?
WebKit Review Bot
Comment 3 2012-09-29 19:29:43 PDT
Comment on attachment 166354 [details] patch Clearing flags on attachment: 166354 Committed r129988: <http://trac.webkit.org/changeset/129988>
WebKit Review Bot
Comment 4 2012-09-29 19:29:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.