Summary: | flexbox does wrong baseline item alignment in columns | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||||
Component: | Layout and Rendering | Assignee: | Tony Chang <tony> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, ojan, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 62048 | ||||||||||
Attachments: |
|
Description
Tony Chang
2012-09-28 15:58:06 PDT
Created attachment 166555 [details]
Patch
Comment on attachment 166555 [details]
Patch
What if, instead of changing the logic of AlignBaseline, we made the chunk before the switch statement pretend that we have a different alignment. That would reduce some code duplication and more clearly match the spec text.
FlexAlign alignment = alignmentForChild(child);
if (alignment == AlignBaseline and hasOrthogonalFlow(child))
alignment = (style()->flexWrap() == FlexWrapReverse) ? AlignFlexEnd : AlignFlexStart;
Up to you. I find this logic easier to follow.
Created attachment 166563 [details]
Patch
Created attachment 166564 [details]
Patch
Comment on attachment 166564 [details]
Patch
Can you take another look? I moved the logic into alignmentForChild.
Comment on attachment 166564 [details] Patch Rejecting attachment 166564 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 159019 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 159019. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14089966 Comment on attachment 166564 [details] Patch Attachment 166564 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14084986 New failing tests: http/tests/workers/terminate-during-sync-operation.html Comment on attachment 166564 [details] Patch Clearing flags on attachment: 166564 Committed r130110: <http://trac.webkit.org/changeset/130110> All reviewed patches have been landed. Closing bug. |