Bug 97893

Summary: REGRESSION(r127727): Calendar picker is ignoring step
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Keishi Hattori 2012-09-28 04:42:25 PDT 
Calendar picker is ignoring step and showing all dates as available
Comment 1 Keishi Hattori 2012-09-30 21:57:20 PDT 
Created attachment 166406 [details]
Patch
Comment 2 Kent Tamura 2012-09-30 22:06:13 PDT 
Comment on attachment 166406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166406&action=review

> Source/WebCore/ChangeLog:8
> +        There were two mistakes. If statement was wrong and DateTimeChooserParameters.step was number of milliseconds when it should be number of days.

"If statement was ..."  is a very confusing sentence.  should be "An if-statement was ..."
Also, bulletizing improves readability.  e.g.

There were two mistakes:
 - An if-statement to check step attribute validity was wrong, and
 - DateTiemChooserParameters.step was milleseconds when it should be number of days.
Comment 3 Keishi Hattori 2012-09-30 23:03:57 PDT 
Created attachment 166407 [details]
Patch
Comment 4 Keishi Hattori 2012-09-30 23:17:39 PDT 
Created attachment 166409 [details]
Patch
Comment 5 WebKit Review Bot 2012-09-30 23:21:11 PDT 
Comment on attachment 166409 [details]
Patch

Rejecting attachment 166409 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14075812
Comment 6 Keishi Hattori 2012-09-30 23:22:58 PDT 
Created attachment 166410 [details]
Patch
Comment 7 WebKit Review Bot 2012-10-01 00:14:56 PDT 
Comment on attachment 166410 [details]
Patch

Clearing flags on attachment: 166410

Committed r130008: <http://trac.webkit.org/changeset/130008>
Comment 8 WebKit Review Bot 2012-10-01 00:14:59 PDT 
All reviewed patches have been landed.  Closing bug.