Calendar picker is ignoring step and showing all dates as available
Created attachment 166406 [details]
Comment on attachment 166406 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=166406&action=review
> + There were two mistakes. If statement was wrong and DateTimeChooserParameters.step was number of milliseconds when it should be number of days.
"If statement was ..." is a very confusing sentence. should be "An if-statement was ..."
Also, bulletizing improves readability. e.g.
There were two mistakes:
- An if-statement to check step attribute validity was wrong, and
- DateTiemChooserParameters.step was milleseconds when it should be number of days.
Created attachment 166407 [details]
Created attachment 166409 [details]
Comment on attachment 166409 [details]
Rejecting attachment 166409 [details] from commit-queue.
Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Full output: http://queues.webkit.org/results/14075812
Created attachment 166410 [details]
Comment on attachment 166410 [details]
Clearing flags on attachment: 166410
Committed r130008: <http://trac.webkit.org/changeset/130008>
All reviewed patches have been landed. Closing bug.