Bug 97889

Summary: Port SimpleFontDataWin.cpp to WinCE
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Patch none

Patrick R. Gansterer
Reported 2012-09-28 04:18:03 PDT
Port SimpleFontDataWin.cpp to WinCE
Attachments
Patch (5.03 KB, patch)
2012-09-28 04:26 PDT, Patrick R. Gansterer 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2012-09-28 05:08 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-09-28 04:26:50 PDT
Created attachment 166204 [details] Patch
Patrick R. Gansterer
Comment 2 2012-09-28 04:28:15 PDT
Comment on attachment 166204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166204&action=review > Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp:255 > + GetTextExtentPoint32W(hdc, &c, 1, &fontSize); It's the code from http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/wince/SimpleFontDataWinCE.cpp?rev=104545#L165
Build Bot
Comment 3 2012-09-28 04:49:43 PDT
Comment on attachment 166204 [details] Patch Attachment 166204 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14066212
Patrick R. Gansterer
Comment 4 2012-09-28 05:08:23 PDT
Created attachment 166217 [details] Patch
Patrick R. Gansterer
Comment 5 2012-09-28 06:18:25 PDT
Comment on attachment 166217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166217&action=review > Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp:255 > + GetTextExtentPoint32W(hdc, &c, 1, &fontSize); http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/wince/SimpleFontDataWinCE.cpp?rev=104545#L165
Brent Fulgham
Comment 6 2012-11-13 11:00:18 PST
Comment on attachment 166217 [details] Patch Change looks good. Thanks!
WebKit Review Bot
Comment 7 2012-11-13 11:31:48 PST
Comment on attachment 166217 [details] Patch Clearing flags on attachment: 166217 Committed r134453: <http://trac.webkit.org/changeset/134453>
WebKit Review Bot
Comment 8 2012-11-13 11:31:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.