Bug 97887

Summary: [EFL][WK2] Remove "web" word from ewk_resource APIs
Product: WebKit Reporter: Jongseok Yang <js45.yang>
Component: WebKit EFLAssignee: Jongseok Yang <js45.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Jongseok Yang
Reported 2012-09-28 03:50:22 PDT
"ewk" means "EFL WebKit" and "web" word for the name ewk_web_resource implementation is redundant. So, it' better to remove "web" word from them. The patch will be uploaded soon.
Attachments
Patch (33.35 KB, patch)
2012-10-04 19:46 PDT, Jongseok Yang 		no flags
DetailsFormatted DiffDiff
Patch (33.34 KB, patch)
2012-10-04 19:56 PDT, Jongseok Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jongseok Yang
Comment 1 2012-10-04 19:46:56 PDT
Created attachment 167235 [details] Patch
WebKit Review Bot
Comment 2 2012-10-04 19:49:02 PDT
Attachment 167235 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/efl/ewk_resource.cpp:34: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jongseok Yang
Comment 3 2012-10-04 19:56:32 PDT
Created attachment 167236 [details] Patch
Chris Dumez
Comment 4 2012-10-04 22:36:52 PDT
Comment on attachment 167236 [details] Patch Looks good. Thanks.
Gyuyoung Kim
Comment 5 2012-10-05 00:39:07 PDT
For the record, http://lists.webkit.org/pipermail/webkit-efl/2012-September/000308.html
WebKit Review Bot
Comment 6 2012-10-05 00:46:49 PDT
Comment on attachment 167236 [details] Patch Clearing flags on attachment: 167236 Committed r130479: <http://trac.webkit.org/changeset/130479>
WebKit Review Bot
Comment 7 2012-10-05 00:46:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.