Bug 97881

Summary: [EFL][DRT] EFL DRT should disable visited links tracking by default
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch v2
none
patch v3 none

Mikhail Pozdnyakov
Reported 2012-09-28 03:11:42 PDT
EFL DRT should disable visited links tracking by default in order to be consistent with WKTR. And thus both WK1 EFL and WK2 EFL can have similar results for fast/block/float/float-in-float-hit-testing.html
Attachments
patch (7.58 KB, patch)
2012-09-28 03:16 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch (6.94 KB, patch)
2012-09-28 03:19 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v2 (58.80 KB, patch)
2012-09-28 03:46 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v3 (58.89 KB, patch)
2012-09-28 03:54 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-09-28 03:16:32 PDT
Created attachment 166191 [details] patch
Mikhail Pozdnyakov
Comment 2 2012-09-28 03:17:21 PDT
Comment on attachment 166191 [details] patch oops, left something uneeded in TestExpectations.
Mikhail Pozdnyakov
Comment 3 2012-09-28 03:19:15 PDT
Created attachment 166192 [details] patch
Chris Dumez
Comment 4 2012-09-28 03:25:49 PDT
Comment on attachment 166192 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=166192&action=review > LayoutTests/platform/efl-wk2/TestExpectations:-194 > -# Visited link color is incorrect I think there is at least one similar test in wk2 global Skipped list. > LayoutTests/platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt:22 > + RenderInline {A} at (0,0) size 245x112 [color=#0000EE] Pixel test rebaseline as well. > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:110 > + Useless extra line.
Mikhail Pozdnyakov
Comment 5 2012-09-28 03:46:25 PDT
Created attachment 166196 [details] patch v2 Comments from Chris are addressed.
Mikhail Pozdnyakov
Comment 6 2012-09-28 03:54:36 PDT
Created attachment 166197 [details] patch v3 Little corrections to TestExpectations and LayoutTests/ChangeLog.
Chris Dumez
Comment 7 2012-09-28 03:56:48 PDT
Comment on attachment 166197 [details] patch v3 LGTM.
WebKit Review Bot
Comment 8 2012-09-28 04:14:47 PDT
Comment on attachment 166197 [details] patch v3 Clearing flags on attachment: 166197 Committed r129874: <http://trac.webkit.org/changeset/129874>
WebKit Review Bot
Comment 9 2012-09-28 04:14:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.