Bug 97879

Summary: Web Inspector: make HashSet memory instrumentation non-intrusive
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, benjamin, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Yury Semikhatsky
Reported 2012-09-28 02:59:19 PDT
Declaring reportMemoryUsage as a friend of HashSet and HashTable is considered harmful, so we should switch to using only public API of the classes. This way we will still be able to collect necessary information. The problem is that it will be easier to change the implementation and forget to update the instrumentation(which is probably fine since these classes don't change often), also we won't be able to automatically mark corresponding objects in the memory as instrumented while checking correctness of the memory instrumentation.
Attachments
Patch (14.84 KB, patch)
2012-09-28 03:04 PDT, Yury Semikhatsky 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-09-28 03:04:19 PDT
Created attachment 166187 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-09-28 03:09:01 PDT
Comment on attachment 166187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166187&action=review lgtm > Source/WebKit/chromium/ChangeLog:8 > + Updatee the test for HashSet memory instrumentation. We don't add typo: Updatee
Yury Semikhatsky
Comment 3 2012-09-28 04:15:52 PDT
Comment on attachment 166187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166187&action=review >> Source/WebKit/chromium/ChangeLog:8 >> + Updatee the test for HashSet memory instrumentation. We don't add > > typo: Updatee Done.
Yury Semikhatsky
Comment 4 2012-09-28 04:21:33 PDT
Committed r129875: <http://trac.webkit.org/changeset/129875>
Note You need to log in before you can comment on or make changes to this bug.