| Summary: | [Forms] Multiple fields week input UI | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | yosin | ||||||||
| Component: | Forms | Assignee: | yosin | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cmarcelo, macpherson, menard, mifenton, tkent, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 97992, 98104, 100128, 102045 | ||||||||||
| Bug Blocks: | 29359, 98006 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
yosin
2012-09-28 02:46:09 PDT
Created attachment 166432 [details]
Patch 1
Comment on attachment 166432 [details]
Patch 1
Could you review this patch?
Thanks in advance.
Comment on attachment 166432 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=166432&action=review > Source/WebCore/html/WeekInputType.cpp:45 > +#include "Localizer.h" Is this needed? Created attachment 166434 [details]
Patch 2
Comment on attachment 166434 [details]
Patch 2
Could you review this patch?
Thanks in advance.
= Changes since the last review =
* Remove unused include file Localizer.h from WeekInputType.cpp
Comment on attachment 166434 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=166434&action=review ok except ChangeLog > Source/WebCore/ChangeLog:19 > + - fast/forms/month/month-stepup-stepdown-from-renderer.html fast/forms/week/week-... Created attachment 166439 [details]
Patch 3
Comment on attachment 166439 [details] Patch 3 Clearing flags on attachment: 166439 Committed r130024: <http://trac.webkit.org/changeset/130024> All reviewed patches have been landed. Closing bug. |