Summary: | [Forms] Adding DateTimeMonthFieldElement and DateTimeYearFieldElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||
Component: | Forms | Assignee: | yosin | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | tkent | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 97299 | ||||||
Attachments: |
|
Description
yosin
2012-09-27 22:35:10 PDT
Created attachment 166153 [details]
Patch 1
Comment on attachment 166153 [details]
Patch 1
Could you review this patch?
Thanks in advance.
Comment on attachment 166153 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=166153&action=review > Source/WebCore/ChangeLog:26 > + Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME > + and ENABLE_INPUT_MULTIPLE_FIELDS_UI. Looks wrong. INPUT_TYPE_TIME is unrelated. > Source/WebCore/ChangeLog:52 > + (WebCore::DateTimeNumericFieldElement::stepDown): Changed to use defaultValueForStepDown instead of maximum field value. > + (WebCore::DateTimeNumericFieldElement::stepUp): Changed to use defaultValueForStepUp minium field value. > + (WebCore::DateTimeNumericFieldElement::value): Changed to use "%04d" when maximum field value is greater than 999 for year field. They should be "why" comments. "what" comments are not helpful in many cases. Comment on attachment 166153 [details] Patch 1 Clearing flags on attachment: 166153 Committed r129855: <http://trac.webkit.org/changeset/129855> All reviewed patches have been landed. Closing bug. |