Summary: | Results page should warn about time-dependent distributions | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | jhammel, kling, koivisto, morrita, ojan, zoltan | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 77037 | ||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-09-27 13:28:39 PDT
Created attachment 166053 [details]
WIP Demo
Created attachment 166055 [details]
WIP Demo
Created attachment 166070 [details]
Implements the feature
Created attachment 166071 [details]
Sample output
Comment on attachment 166070 [details] Implements the feature View in context: https://bugs.webkit.org/attachment.cgi?id=166070&action=review > PerformanceTests/resources/results-template.html:304 > + container.append('<div></div>'); Maybe put a title on these so that the mouseover tooltip can give some indication of what these are for? Comment on attachment 166070 [details] Implements the feature View in context: https://bugs.webkit.org/attachment.cgi?id=166070&action=review > PerformanceTests/resources/results-template.html:409 > +var warningSign = '<svg viewBox="0 0 100 100" style="width: 18px; height: 18px; vertical-align: bottom;" version="1.1">' Or maybe put the title on this? It's confusing to have a warning icon without any explanation. Comment on attachment 166070 [details] Implements the feature View in context: https://bugs.webkit.org/attachment.cgi?id=166070&action=review >> PerformanceTests/resources/results-template.html:409 >> +var warningSign = '<svg viewBox="0 0 100 100" style="width: 18px; height: 18px; vertical-align: bottom;" version="1.1">' > > Or maybe put the title on this? It's confusing to have a warning icon without any explanation. This svg element is wrapped in a span with a title. See line 442. Comment on attachment 166070 [details] Implements the feature Attachment 166070 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14061028 New failing tests: http/tests/workers/terminate-during-sync-operation.html Committed r129813: <http://trac.webkit.org/changeset/129813> |