Bug 97814

Summary: Add webkit_unit_tests to the flakiness dashboard
Product: WebKit Reporter: Julie Parent <jparent>
Component: New BugsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Julie Parent
Reported 2012-09-27 13:19:03 PDT
Add webkit_unit_tests to the flakiness dashboard
Attachments
Patch (2.28 KB, patch)
2012-09-27 13:20 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.27 KB, patch)
2012-09-27 14:28 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2012-09-27 13:20:17 PDT
Created attachment 166049 [details] Patch
Julie Parent
Comment 2 2012-09-27 14:28:56 PDT
Created attachment 166063 [details] Patch for landing
WebKit Review Bot
Comment 3 2012-09-27 14:56:50 PDT
Comment on attachment 166063 [details] Patch for landing Rejecting attachment 166063 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/mac/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13967089
Adam Barth
Comment 4 2012-09-27 14:58:11 PDT
Comment on attachment 166063 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=166063&action=review > Tools/ChangeLog:6 > + Reviewed by Dirk Pranke. This line looks right. I'm not sure why the bot complained.
Adam Barth
Comment 5 2012-09-27 15:00:50 PDT
Comment on attachment 166063 [details] Patch for landing Clearing flags on attachment: 166063 Committed r129805: <http://trac.webkit.org/changeset/129805>
Adam Barth
Comment 6 2012-09-27 15:00:53 PDT
All reviewed patches have been landed. Closing bug.
Julie Parent
Comment 7 2012-09-27 15:02:02 PDT
I just used webkit-patch land-safely, not sure why the changelog would have been incorrect. Thanks Adam!
Note You need to log in before you can comment on or make changes to this bug.