Bug 97805

Summary: [Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: Tools / TestsAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-09-27 11:23:06 PDT
Support for non-array modifier arguments to DRT's keydown has been added by other ports. So, implement this on Mac too, to be consistent with the other ports.
Attachments
Patch (2.81 KB, patch)
2012-09-27 11:43 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (2.78 KB, patch)
2012-09-27 13:10 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-09-27 11:43:54 PDT
Created attachment 166038 [details] Patch
Alexey Proskuryakov
Comment 2 2012-09-27 12:23:18 PDT
Comment on attachment 166038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166038&action=review > Tools/DumpRenderTree/mac/EventSendingController.mm:302 > +static int applyKeyModifierFlags(const NSString* modifierName) Why is this function called "apply..."? It doesn't seem to apply them to anything.
Sudarsana Nagineni (babu)
Comment 3 2012-09-27 13:10:08 PDT
Created attachment 166047 [details] Patch Taken Alexey's feedback into consideration.
WebKit Review Bot
Comment 4 2012-09-27 14:43:46 PDT
Comment on attachment 166047 [details] Patch Clearing flags on attachment: 166047 Committed r129802: <http://trac.webkit.org/changeset/129802>
WebKit Review Bot
Comment 5 2012-09-27 14:43:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.