Bug 97805

Summary: [Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: Tools / TestsAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sudarsana Nagineni (babu) 2012-09-27 11:23:06 PDT
Support for non-array modifier arguments to DRT's keydown has been added by other ports. So, implement this on Mac too, to be consistent with the other ports.
Comment 1 Sudarsana Nagineni (babu) 2012-09-27 11:43:54 PDT
Created attachment 166038 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-09-27 12:23:18 PDT
Comment on attachment 166038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166038&action=review

> Tools/DumpRenderTree/mac/EventSendingController.mm:302
> +static int applyKeyModifierFlags(const NSString* modifierName)

Why is this function called "apply..."? It doesn't seem to apply them to anything.
Comment 3 Sudarsana Nagineni (babu) 2012-09-27 13:10:08 PDT
Created attachment 166047 [details]
Patch

Taken Alexey's feedback into consideration.
Comment 4 WebKit Review Bot 2012-09-27 14:43:46 PDT
Comment on attachment 166047 [details]
Patch

Clearing flags on attachment: 166047

Committed r129802: <http://trac.webkit.org/changeset/129802>
Comment 5 WebKit Review Bot 2012-09-27 14:43:49 PDT
All reviewed patches have been landed.  Closing bug.