Bug 97805 - [Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
Summary: [Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 11:23 PDT by Sudarsana Nagineni (babu)
Modified: 2012-09-27 14:43 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.81 KB, patch)
2012-09-27 11:43 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff
Patch (2.78 KB, patch)
2012-09-27 13:10 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-09-27 11:23:06 PDT
Support for non-array modifier arguments to DRT's keydown has been added by other ports. So, implement this on Mac too, to be consistent with the other ports.
Comment 1 Sudarsana Nagineni (babu) 2012-09-27 11:43:54 PDT
Created attachment 166038 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-09-27 12:23:18 PDT
Comment on attachment 166038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166038&action=review

> Tools/DumpRenderTree/mac/EventSendingController.mm:302
> +static int applyKeyModifierFlags(const NSString* modifierName)

Why is this function called "apply..."? It doesn't seem to apply them to anything.
Comment 3 Sudarsana Nagineni (babu) 2012-09-27 13:10:08 PDT
Created attachment 166047 [details]
Patch

Taken Alexey's feedback into consideration.
Comment 4 WebKit Review Bot 2012-09-27 14:43:46 PDT
Comment on attachment 166047 [details]
Patch

Clearing flags on attachment: 166047

Committed r129802: <http://trac.webkit.org/changeset/129802>
Comment 5 WebKit Review Bot 2012-09-27 14:43:49 PDT
All reviewed patches have been landed.  Closing bug.