Bug 97803

Summary: Port DragDataWin.cpp to WinCE
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gyuyoung.kim, rakuco, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2012-09-27 10:50:29 PDT
Port DragDataWin.cpp to WinCE
Attachments
Patch (5.03 KB, patch)
2012-09-27 10:54 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (5.33 KB, patch)
2012-09-28 04:39 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-09-27 10:54:18 PDT
Created attachment 166031 [details] Patch
Patrick R. Gansterer
Comment 2 2012-09-28 04:39:03 PDT
Created attachment 166207 [details] Patch
Brent Fulgham
Comment 3 2012-11-19 23:08:35 PST
Comment on attachment 166207 [details] Patch Looks good to me. You might need to land this manually, as it's been a while since you submitted the patch for review.
WebKit Review Bot
Comment 4 2012-11-19 23:14:05 PST
Comment on attachment 166207 [details] Patch Clearing flags on attachment: 166207 Committed r135255: <http://trac.webkit.org/changeset/135255>
WebKit Review Bot
Comment 5 2012-11-19 23:14:09 PST
All reviewed patches have been landed. Closing bug.
Yury Semikhatsky
Comment 6 2012-11-19 23:51:28 PST
(In reply to comment #4) > (From update of attachment 166207 [details]) > Clearing flags on attachment: 166207 > > Committed r135255: <http://trac.webkit.org/changeset/135255> This change broke Chromium Win compilation: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/31361 I landed fix in http://trac.webkit.org/changeset/135258
Brent Fulgham
Comment 7 2012-11-20 11:07:02 PST
Whoops! Patrick, looks like the various gyp files need to be gripped when removing files!
Note You need to log in before you can comment on or make changes to this bug.