Bug 97766

Summary: [WK2] Injected bundle API implementation should use toWTFString()
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit2Assignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, benjamin, gyuyoung.kim, gyuyoung.kim, kenneth, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Mikhail Pozdnyakov 2012-09-27 01:17:51 PDT 
Injected bundle API implementations should call toWTFString() rather than convert WKStringRef and WKURLRef to their impls and then call string() method directly. Rational for that is:
1) safety (toWTFString checks the given pointer)
2) code readability
Comment 1 Mikhail Pozdnyakov 2012-09-27 01:25:13 PDT 
Created attachment 165949 [details]
patch
Comment 2 WebKit Review Bot 2012-09-27 02:32:18 PDT 
Comment on attachment 165949 [details]
patch

Clearing flags on attachment: 165949

Committed r129743: <http://trac.webkit.org/changeset/129743>
Comment 3 WebKit Review Bot 2012-09-27 02:32:22 PDT 
All reviewed patches have been landed.  Closing bug.