Bug 97756

Summary: [Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97521    
Bug Blocks:    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-09-26 21:13:13 PDT
We used containment instead of inheritance for implementing DateTimeEditElement::EditControlOwner interface when we implemented in TimeInputType class to use BaseDateAndTimeInputType as base class of TimeInputType regardless single field UI or multiple fields UI. Once we use different base class based on single field UI or multiple fields UI, we can put DateTimeEditElement::EditControlOwner interface into base class list of BaseMultipleFieldsDateAndTimeInputType class.
Attachments
Patch 1 (9.02 KB, patch)
2012-09-27 00:08 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-27 00:08:27 PDT
Created attachment 165940 [details] Patch 1
yosin
Comment 2 2012-09-27 00:10:45 PDT
Comment on attachment 165940 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-09-27 00:32:07 PDT
Comment on attachment 165940 [details] Patch 1 ok
yosin
Comment 4 2012-09-27 01:21:43 PDT
Comment on attachment 165940 [details] Patch 1 Clearing flags on attachment: 165940 Committed r129739: <http://trac.webkit.org/changeset/129739>
yosin
Comment 5 2012-09-27 01:21:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.