Bug 97751

Summary:

webkitpy: make warning about missing BUG identifiers per-port configurable

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, ojan, rniwa, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	ojan: review+

Dirk Pranke

Reported 2012-09-26 19:20:17 PDT

webkitpy: make warning about missing BUG identifiers per-port configurable

Attachments
Patch (5.91 KB, patch) 2012-09-26 19:23 PDT, Dirk Pranke	ojan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2012-09-26 19:23:24 PDT

Ojan Vafai

Comment 2 2012-09-26 21:31:05 PDT

Comment on attachment 165917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165917&action=review Seems like a reasonable path forward. > Tools/Scripts/webkitpy/layout_tests/port/base.py:1005 > + def warn_if_bug_missing_in_test_expectations(self): > + return False > + I assume this copy-paste was accidental?

Dirk Pranke

Comment 3 2012-09-27 10:13:42 PDT

Comment on attachment 165917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165917&action=review >> Tools/Scripts/webkitpy/layout_tests/port/base.py:1005 >> + > > I assume this copy-paste was accidental? whoops. Yes :).

Dirk Pranke

Comment 4 2012-09-27 11:59:53 PDT

Note You need to log in before you can comment on or make changes to this bug.