Bug 97748
| Summary: | testRunner.setFrameFlatteningEnabled only affects the main frame, not nested frames | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | abarth, kenneth, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
I was trying to figure out why a frame flattening test didn't behave as I expected. It turns out that testRunner.setFrameFlatteningEnabled(true); only affects the main frame, not nested frames. This makes it impossible to use to compare with mobile devices which set that everywhere.
Maybe testRunner.settings should always "go deep"?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
testRunner.settings should change WebCore::Settings, which is per-page. I haven't looked into setFrameFlatteningEnabled, so I don't know what that does.
Kenneth Rohde Christiansen
frame flattening kind of only makes sense if it is applied everywhere, thus also for nested frames, so it makes sense that that setting goes deep.
Is it already inherited by new frames after the setting has been set?
Simon Fraser (smfr)
I may have made a hasty assumption here. Will debug more this afternoon.
Alexey Proskuryakov
Renaming to match bug description for now. I agree with Adam, original title does not seem accurate.
Simon Fraser (smfr)
I'm debugging a test that navigates. m_frameFlatteningEnabled is false on the Page's Settings, but I'm not sure how it gets that way.
Simon Fraser (smfr)
I was confused. See bug 97841 for what I was investigating.