Bug 97745

Summary: [Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
Product: WebKit Reporter: Helder Correia <helder.correia>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Helder Correia
Reported 2012-09-26 17:52:08 PDT
In LayerTreeCoordinator::adoptImageBackingStore(), there is a PLATFORM(QT) code path to check for identical images, but nothing is done for Cairo, which results in the occurrence of avoidable resource allocations. The issue happens in e.g. http://www.webkit.org/blog-files/leaves/, where there are many leaves flying around while they're produced out of only four bitmaps.
Attachments
Patch (3.14 KB, patch)
2012-09-26 18:12 PDT, Helder Correia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2012-09-26 18:12:13 PDT
Created attachment 165908 [details] Patch
WebKit Review Bot
Comment 2 2012-09-27 12:44:14 PDT
Comment on attachment 165908 [details] Patch Clearing flags on attachment: 165908 Committed r129791: <http://trac.webkit.org/changeset/129791>
WebKit Review Bot
Comment 3 2012-09-27 12:44:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.