Bug 97745

Summary:

[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images

Product:

WebKit

Reporter:

Helder Correia <helder.correia>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, noam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Helder Correia 2012-09-26 17:52:08 PDT

In LayerTreeCoordinator::adoptImageBackingStore(), there is a PLATFORM(QT) code path to check for identical images, but nothing is done for Cairo, which results in the occurrence of avoidable resource allocations. The issue happens in e.g. http://www.webkit.org/blog-files/leaves/, where there are many leaves flying around while they're produced out of only four bitmaps.

Comment 1 Helder Correia 2012-09-26 18:12:13 PDT

Created attachment 165908 [details]
Patch

Comment 2 WebKit Review Bot 2012-09-27 12:44:14 PDT

Comment on attachment 165908 [details]
Patch

Clearing flags on attachment: 165908

Committed r129791: <http://trac.webkit.org/changeset/129791>

Comment 3 WebKit Review Bot 2012-09-27 12:44:17 PDT

All reviewed patches have been landed.  Closing bug.