Summary: | PerfTestRunner.run should take an object | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, haraken, jchaffraix, kling, koivisto, morrita, ojan, ossy, zoltan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 97741 | ||||||||
Bug Blocks: | 97833 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-09-26 17:18:30 PDT
Created attachment 165903 [details]
work in progress
Created attachment 166101 [details]
Cleanup
Comment on attachment 166101 [details]
Cleanup
Looks OK
Wow! That was quick. Thanks. Will land. Committed r129824: <http://trac.webkit.org/changeset/129824> (In reply to comment #5) > Committed r129824: <http://trac.webkit.org/changeset/129824> FYI: It broke the perf test bots - http://build.webkit.org/builders/Qt%20Linux%2064-bit%20Release%20%28Perf%29/builds/5182 I really can't understand why do you always commit without checking locally ... and wait until I notice the regression and ask you to fix it ... (In reply to comment #6) > (In reply to comment #5) > > Committed r129824: <http://trac.webkit.org/changeset/129824> > > FYI: It broke the perf test bots - http://build.webkit.org/builders/Qt%20Linux%2064-bit%20Release%20%28Perf%29/builds/5182 > > I really can't understand why do you always commit without checking locally ... > and wait until I notice the regression and ask you to fix it ... I don't do that. The fix had been landed in http://trac.webkit.org/changeset/129848. Keeping bots green should be a method by which we improve WebKit, not itself a goal. Also, this whole performance-tests-in-WebKit is still under development. We can't treat it like other matured automated test infrastructure we have like layout tests and unit tests. If perf. bots turning red is too distracting, I suggest disconnecting slaves for now. |