Bug 97687

Summary: 4.95MB below RenderBlock::insertIntoTrackedRendererMaps() on Membuster3.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, tonyg, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+
Patch for blending
webkit.review.bot: commit-queue-
Less Anders, more landability. none

Description Andreas Kling 2012-09-26 08:25:44 PDT 
We currently have 4.95MB of allocations below this function on the Membuster3 benchmark.
I suspect it would be easy to reduce this by tweaking the ListHashSets used in the descendants map.
Comment 1 Radar WebKit Bug Importer 2012-09-26 08:26:07 PDT 
<rdar://problem/12376748>
Comment 2 Andreas Kling 2012-09-26 09:03:42 PDT 
Created attachment 165818 [details]
Patch
Comment 3 Anders Carlsson 2012-09-26 09:54:32 PDT 
Comment on attachment 165818 [details]
Patch

Make it 16 and you've got yourself a deal!
Comment 4 Eric Seidel (no email) 2012-09-26 10:24:07 PDT 
Thanks!
Comment 5 Andreas Kling 2012-09-26 11:04:08 PDT 
Created attachment 165833 [details]
Patch for blending
Comment 6 WebKit Review Bot 2012-09-26 11:13:00 PDT 
Comment on attachment 165833 [details]
Patch for blending

Rejecting attachment 165833 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Karl Anders Carlsson found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14033515
Comment 7 Eric Seidel (no email) 2012-09-26 11:20:50 PDT 
Fancified reviewer names don't blend.
Comment 8 Andreas Kling 2012-09-26 11:41:51 PDT 
(In reply to comment #7)
> Fancified reviewer names don't blend.

Aw dangit!
Comment 9 Andreas Kling 2012-09-26 11:43:07 PDT 
Created attachment 165840 [details]
Less Anders, more landability.
Comment 10 WebKit Review Bot 2012-09-26 12:10:37 PDT 
Comment on attachment 165840 [details]
Less Anders, more landability.

Clearing flags on attachment: 165840

Committed r129682: <http://trac.webkit.org/changeset/129682>
Comment 11 WebKit Review Bot 2012-09-26 12:10:41 PDT 
All reviewed patches have been landed.  Closing bug.