Summary: | run-perf-tests must expand environment variables in user provided paths | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Marcelo Lira <marcelo.lira> | ||||
Component: | Tools / Tests | Assignee: | Marcelo Lira <marcelo.lira> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, eric, jesus, ojan, rafael.lobo, rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 77037 | ||||||
Attachments: |
|
Description
Marcelo Lira
2012-09-26 08:25:41 PDT
Created attachment 165810 [details]
Patch
(In reply to comment #1) > Created an attachment (id=165810) [details] > Patch I can confirm the issue since I've faced it as well. (And it's quite annoying after you've been running tests for one hour or so.) Comment on attachment 165810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165810&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:75 > + def _expand_path(option, opt_str, value, parser): > + path = os.path.expandvars(os.path.expanduser(value)) > + setattr(parser.values, option.dest, path) Arguably this should use the Environment abstraction in webkitpy.common. Otherwise, how do you test this? It looks like currently you aren't... :) Comment on attachment 165810 [details] Patch Clearing flags on attachment: 165810 Committed r129683: <http://trac.webkit.org/changeset/129683> All reviewed patches have been landed. Closing bug. |