Bug 97662

Summary: Web Inspector: NMI: replace manual JS external resources counting with MemoryInstrumentation
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, benjamin, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
merge artefacts were removed yurys: review+

Ilya Tikhonovsky
Reported 2012-09-26 05:00:06 PDT
EOM
Attachments
Patch (16.08 KB, patch)
2012-09-26 05:06 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (12.12 KB, patch)
2012-09-26 06:04 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (22.18 KB, patch)
2012-09-26 06:49 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (21.41 KB, patch)
2012-09-26 06:51 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
merge artefacts were removed (21.22 KB, patch)
2012-09-26 07:15 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-09-26 05:06:32 PDT
Created attachment 165770 [details] Patch
Yury Semikhatsky
Comment 2 2012-09-26 05:26:44 PDT
Comment on attachment 165770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165770&action=review > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). Please provide a meaningful change log entry. > Source/WTF/wtf/ArrayBuffer.h:141 > + void reportMemoryUsage(MemoryObjectInfo*) const; We could implement this as an external function.
Ilya Tikhonovsky
Comment 3 2012-09-26 06:04:39 PDT
Created attachment 165778 [details] Patch
Ilya Tikhonovsky
Comment 4 2012-09-26 06:49:17 PDT
Created attachment 165787 [details] Patch
Ilya Tikhonovsky
Comment 5 2012-09-26 06:51:08 PDT
Created attachment 165789 [details] Patch
Ilya Tikhonovsky
Comment 6 2012-09-26 07:10:21 PDT
(In reply to comment #2) > (From update of attachment 165770 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165770&action=review > > > Source/WebCore/ChangeLog:10 > > + No new tests (OOPS!). > > Please provide a meaningful change log entry. > > > Source/WTF/wtf/ArrayBuffer.h:141 > > + void reportMemoryUsage(MemoryObjectInfo*) const; > > We could implement this as an external function. done
Gyuyoung Kim
Comment 7 2012-09-26 07:14:26 PDT
Comment on attachment 165789 [details] Patch Attachment 165789 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14034443
Ilya Tikhonovsky
Comment 8 2012-09-26 07:15:55 PDT
Created attachment 165796 [details] merge artefacts were removed
Ilya Tikhonovsky
Comment 9 2012-09-26 08:21:11 PDT
Committed r129649: <http://trac.webkit.org/changeset/129649>
Note You need to log in before you can comment on or make changes to this bug.