Bug 97634

Summary: Removed ASSERT_CLASS_FITS_IN_CELL
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, eric.carlson, feature-media-reviews, fpizlo, haraken, japhet, mhahnenberg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mhahnenberg: review+, webkit-ews: commit-queue-

Geoffrey Garen
Reported 2012-09-25 23:02:01 PDT
Removed ASSERT_CLASS_FITS_IN_CELL
Attachments
Patch (41.49 KB, patch)
2012-09-25 23:04 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (41.74 KB, patch)
2012-09-25 23:08 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (29.53 KB, patch)
2012-10-11 12:38 PDT, Geoffrey Garen 		mhahnenberg: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2012-09-25 23:04:47 PDT
Created attachment 165734 [details] Patch
Geoffrey Garen
Comment 2 2012-09-25 23:08:41 PDT
Created attachment 165735 [details] Patch
Alexey Proskuryakov
Comment 3 2012-09-27 11:06:44 PDT
Comment on attachment 165735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165735&action=review > Source/JavaScriptCore/ChangeLog:3 > + Removed ASSERT_CLASS_FITS_IN_CELL Rationale? > Source/JavaScriptCore/ChangeLog:11 > + * API/JSCallbackFunction.cpp: > + (JSC): > + * API/JSCallbackObject.cpp: > + (JSC): Please remove the useless "(JSC):" lines.
Geoffrey Garen
Comment 4 2012-09-27 11:26:16 PDT
> Rationale? Our collector now supports arbitrarily sized objects, so the ASSERT is not needed. > Please remove the useless "(JSC):" lines. OK.
Geoffrey Garen
Comment 5 2012-10-11 12:38:02 PDT
Created attachment 168260 [details] Patch
Mark Hahnenberg
Comment 6 2012-10-11 12:49:24 PDT
Comment on attachment 168260 [details] Patch r=me
Early Warning System Bot
Comment 7 2012-10-11 12:52:33 PDT
Comment on attachment 168260 [details] Patch Attachment 168260 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14249886
Geoffrey Garen
Comment 8 2012-10-11 12:54:26 PDT
Committed r131088: <http://trac.webkit.org/changeset/131088>
Note You need to log in before you can comment on or make changes to this bug.