Bug 97629 – http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after being unskipped

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Beth Dakin]

http/tests/security/cross-frame-access-put.html was a skipped test until http://trac.webkit.org/changeset/129486 

Now that is is unskipped, it is failing on the WK2 bots. It's possible that the failure is just a platform difference though since the test indicates that it is still passing. The diff is:

--- /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt
@@ -520,9 +520,9 @@
 ALERT: PASS: window.personalbar should be '[object BarInfo]' and is.
 ALERT: PASS: window.plugins should be 'undefined' and is.
 ALERT: PASS: window.screen should be '[object Screen]' and is.
-ALERT: PASS: window.screenLeft should be '0' and is.
+ALERT: PASS: window.screenLeft should be '-10000' and is.
 ALERT: PASS: window.screenTop matched the expected value.
-ALERT: PASS: window.screenX should be '0' and is.
+ALERT: PASS: window.screenX should be '-10000' and is.
 ALERT: PASS: window.screenY matched the expected value.
 ALERT: PASS: window.scrollbars should be '[object BarInfo]' and is.
 ALERT: PASS: window.scrollX should be '0' and is.

[Beth Dakin]

It looks like WebKitTestRunner is failing to use the fake window origin because _shouldUseFakeOrigin is NO when this test runs.  That doesn't seem right.

[Tim Horton]

(In reply to comment #1)
> It looks like WebKitTestRunner is failing to use the fake window origin because _shouldUseFakeOrigin is NO when this test runs.  That doesn't seem right.

We should probably ditch _shouldUseFakeOrigin and just always use it (and initialize it to wherever we put the window initially).

[Beth Dakin]

Created attachment 165849 [details]
Patch

[Beth Dakin]

Thanks Tim! Committed change: http://trac.webkit.org/changeset/129694