Bug 97623

Summary: webkit-patch optimize-baselines should take a --platform arg
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, hclam, ojan, ossy, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97621    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch ojan: review+

Dirk Pranke
Reported 2012-09-25 18:45:45 PDT
webkit-patch optimize-baselines should take a --platform arg
Attachments
Patch (4.79 KB, patch)
2012-09-25 18:47 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (8.67 KB, patch)
2012-11-02 19:50 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-09-25 18:47:35 PDT
Created attachment 165713 [details] Patch
Dirk Pranke
Comment 2 2012-09-25 18:49:06 PDT
posting for review, but see the comments in the changelog ... this isn't necessarily ready to land (or even a good idea). Also, needs tests :).
WebKit Review Bot
Comment 3 2012-09-25 18:50:19 PDT
Attachment 165713 [details] did not pass style-queue: Traceback (most recent call last): File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 55, in __init__ MultiCommandTool.__init__(self) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 221, in __init__ self.commands = commands or [cls() for cls in self._find_all_commands() if cls.name] File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 185, in __init__ AbstractRebaseliningCommand.__init__(self, options=port_options(platform='port/platform to use. Use glob-style wildcards for multiple ports')) NameError: global name 'port_options' is not defined If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Pranke
Comment 4 2012-09-25 18:59:31 PDT
This patch won't apply properly until the patch in bug 97621 is landed ...
Csaba Osztrogonác
Comment 5 2012-09-26 02:06:34 PDT
Comment on attachment 165713 [details] Patch r-, because it killed the EWS
Csaba Osztrogonác
Comment 6 2012-09-26 02:11:17 PDT
I filed a new bug report to make EWS can handle buggy patches too: https://bugs.webkit.org/show_bug.cgi?id=97647
Dirk Pranke
Comment 7 2012-11-02 19:50:44 PDT
Created attachment 172197 [details] Patch
Dirk Pranke
Comment 8 2012-11-05 11:28:20 PST
Committed r133509: <http://trac.webkit.org/changeset/133509>
Note You need to log in before you can comment on or make changes to this bug.