Bug 97621

Summary: webkit-patch rebaseline-expectations should take a --platform arg
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, ojan, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97623    
Attachments:
Description Flags
Patch
none
Patch ojan: review+

Dirk Pranke
Reported 2012-09-25 18:36:01 PDT
webkit-patch rebaseline-expectations should take a --platform arg
Attachments
Patch (5.82 KB, patch)
2012-09-25 18:37 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (9.83 KB, patch)
2012-11-02 19:35 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-09-25 18:37:02 PDT
Created attachment 165711 [details] Patch
Dirk Pranke
Comment 2 2012-09-25 18:37:31 PDT
Note that this still needs a test ...
Dirk Pranke
Comment 3 2012-11-02 19:35:14 PDT
Created attachment 172195 [details] Patch
Dirk Pranke
Comment 4 2012-11-02 19:36:47 PDT
unfortunately, because of the way the code is structured (with the parallel fork of rebaseline-test-internal) it's hard to really test this very well. I don't think the unit tests for --platform=* add much. I did test a bunch by hand (which is how I discovered the locking problem). Let me know if you want me to split the locking code out into a separate patch.
Ojan Vafai
Comment 5 2012-11-02 22:12:19 PDT
Comment on attachment 172195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172195&action=review > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:157 > + try: Maybe add a FIXME to handle these the same way we do the SCM updates?
Dirk Pranke
Comment 6 2012-11-05 10:34:31 PST
(In reply to comment #5) > (From update of attachment 172195 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172195&action=review > > > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:157 > > + try: > > Maybe add a FIXME to handle these the same way we do the SCM updates? Will do. I'm actually thinking about reworking the way we do parallelism differently; given that the slow part is fetching the URLs, maybe we should just do that in parallel and do the rest of the work all at once (as if we were rebaselining locally). I'll probably fool around with this approach and see how it goes ...
Dirk Pranke
Comment 7 2012-11-05 11:26:54 PST
Committed r133508: <http://trac.webkit.org/changeset/133508>
Note You need to log in before you can comment on or make changes to this bug.