Bug 97609

Summary: DelayNode must take sample-accurate delay times into account
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, feature-media-reviews, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Rogers
Reported 2012-09-25 15:05:38 PDT
DelayNode must take sample-accurate delay times into account
Attachments
Patch (5.63 KB, patch)
2012-09-25 15:13 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (5.63 KB, patch)
2012-09-25 15:41 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2012-09-25 15:13:31 PDT
Created attachment 165683 [details] Patch
WebKit Review Bot
Comment 2 2012-09-25 15:35:34 PDT
Comment on attachment 165683 [details] Patch Attachment 165683 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14035188
Chris Rogers
Comment 3 2012-09-25 15:41:16 PDT
Created attachment 165691 [details] Patch
Kenneth Russell
Comment 4 2012-09-26 11:10:23 PDT
Comment on attachment 165691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165691&action=review Looks fine as far as I can tell. r=me. Would be nice to have a layout test. > Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp:116 > + delayTime = max(0.0, delayTime); Would be nice to have a templatized "clamp" primitive somewhere.
WebKit Review Bot
Comment 5 2012-09-26 12:06:17 PDT
Comment on attachment 165691 [details] Patch Clearing flags on attachment: 165691 Committed r129681: <http://trac.webkit.org/changeset/129681>
WebKit Review Bot
Comment 6 2012-09-26 12:06:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.