Summary: | DelayNode must take sample-accurate delay times into account | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||||
Component: | New Bugs | Assignee: | Chris Rogers <crogers> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, eric.carlson, feature-media-reviews, kbr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Rogers
2012-09-25 15:05:38 PDT
Created attachment 165683 [details]
Patch
Comment on attachment 165683 [details] Patch Attachment 165683 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14035188 Created attachment 165691 [details]
Patch
Comment on attachment 165691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165691&action=review Looks fine as far as I can tell. r=me. Would be nice to have a layout test. > Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp:116 > + delayTime = max(0.0, delayTime); Would be nice to have a templatized "clamp" primitive somewhere. Comment on attachment 165691 [details] Patch Clearing flags on attachment: 165691 Committed r129681: <http://trac.webkit.org/changeset/129681> All reviewed patches have been landed. Closing bug. |