Bug 97553

Summary: [GTK] Add Undo / Redo method to WebKit2 GTK+ API
Product: WebKit Reporter: Simon Pena <spena>
Component: WebKit2Assignee: Simon Pena <spena>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, gyuyoung.kim, mrobinson, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Pena
Reported 2012-09-25 04:23:40 PDT
[GTK] Add Undo / Redo method to WebKit2 GTK+ API
Attachments
Patch (3.03 KB, patch)
2012-09-25 04:25 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2012-09-25 07:49 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Pena
Comment 1 2012-09-25 04:25:12 PDT
Created attachment 165579 [details] Patch
WebKit Review Bot
Comment 2 2012-09-25 04:27:08 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2012-09-25 06:36:15 PDT
Comment on attachment 165579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82 > + * webkit_web_view_can_execute_editing_command(). It's only possible > + * to undo a command when it has been previously issued. Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here?
Simon Pena
Comment 4 2012-09-25 06:44:20 PDT
(In reply to comment #3) > (From update of attachment 165579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82 > > + * webkit_web_view_can_execute_editing_command(). It's only possible > > + * to undo a command when it has been previously issued. > > Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here? I guess this is a language mistake from my side. I meant that you need to generate a command if you want to later undo it, and to generate a command you'll need some interaction.
Martin Robinson
Comment 5 2012-09-25 07:24:45 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 165579 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review > > > > > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82 > > > + * webkit_web_view_can_execute_editing_command(). It's only possible > > > + * to undo a command when it has been previously issued. Maybe just say "It's only possible to undo a command after a previously executed editing operation." I think that covers the case of the operation coming from either the WebKit API or the user.
Simon Pena
Comment 6 2012-09-25 07:49:40 PDT
Created attachment 165613 [details] Patch
WebKit Review Bot
Comment 7 2012-09-25 08:18:29 PDT
Comment on attachment 165613 [details] Patch Clearing flags on attachment: 165613 Committed r129510: <http://trac.webkit.org/changeset/129510>
WebKit Review Bot
Comment 8 2012-09-25 08:18:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.