Bug 97551 – Add tests for datalist UI for input type date

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Add tests for datalist UI for input type date

[Keishi Hattori]

Created attachment 165595 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165595 [details]
Patch

Attachment 165595 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14033050

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html
platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html

[Kent Tamura]

Comment on attachment 165595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165595&action=review

> LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:25
> +    <option label="-">2012-01-21</option>

What's the intention of this label="-"?

> LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:74
> +    <option>2012-03-08</option>
> +    <option>2012-01-00</option> <!--invalid-->
> +    <option>foo</option> <!--invalid-->

* I don't think we need such large number of options in this test. 20 + a few would be enough.
* Invalid options should be younger children in order to check whether they are omitted or not.

[Keishi Hattori]

Created attachment 165733 [details]
Patch

[Keishi Hattori]

(In reply to comment #3)
> (From update of attachment 165595 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165595&action=review
> 
> > LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:25
> > +    <option label="-">2012-01-21</option>
> 
> What's the intention of this label="-"?
Removed. It was there to mark page breaks.

> > LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:74
> > +    <option>2012-03-08</option>
> > +    <option>2012-01-00</option> <!--invalid-->
> > +    <option>foo</option> <!--invalid-->
> 
> * I don't think we need such large number of options in this test. 20 + a few would be enough.
> * Invalid options should be younger children in order to check whether they are omitted or not.

Done.

[Kent Tamura]

Comment on attachment 165733 [details]
Patch

ok for these tests.

We should have other tests:
 - Appearance of hovered/selected suggestion
 - Appearance of the button with OtherDateLabel
 - Check if clicking the OtherDataLabel button switches the popup to CalendarPicker

[Kent Tamura]

Comment on attachment 165733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165733&action=review

> LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html:156
> +    var offset = cumulativeOffset(element);
> +    var centerX = offset[0] + element.offsetWidth / 2;
> +    var centerY = offset[1] + element.offsetHeight / 2;
> +    eventSender.mouseMoveTo(centerX, centerY);

we can replace this with hoverOverElement(element).

[Keishi Hattori]

Created attachment 165742 [details]
Patch

[Kent Tamura]

Comment on attachment 165742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165742&action=review

> LayoutTests/ChangeLog:10
> +        * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.

The picker width is slightly wider than the input width.  Is it expected?

[Keishi Hattori]

Created attachment 165752 [details]
Patch

[Keishi Hattori]

(In reply to comment #9)
> (From update of attachment 165742 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165742&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
> 
> The picker width is slightly wider than the input width.  Is it expected?

It was a regression.

Modified the test so date-suggestion-picker-appearance.html is testing when the input width is wider than the suggestion width, date-suggestion-picker-appearance-with-scroll-bar.html is testing when suggestion width is wider than the input width.

[Kent Tamura]

Comment on attachment 165752 [details]
Patch

looks good

[WebKit Review Bot]

Comment on attachment 165752 [details]
Patch

Rejecting attachment 165752 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html
Full output: http://queues.webkit.org/results/14018479

[WebKit Review Bot]

Comment on attachment 165752 [details]
Patch

Attachment 165752 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14027489

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html

[WebKit Review Bot]

Comment on attachment 165752 [details]
Patch

Rejecting attachment 165752 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html
Full output: http://queues.webkit.org/results/14032651

[Keishi Hattori]

Created attachment 165919 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165919 [details]
Patch

Clearing flags on attachment: 165919

Committed r129726: <http://trac.webkit.org/changeset/129726>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.