Bug 97542

Summary: [WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2012-09-25 02:52:03 PDT
setWillSendRequestReturnsNullOnRedirect() is currently not supported by WebKitTestRunner causing the following test to fail on WK2: http/tests/misc/will-send-request-returns-null-on-redirect.html
Attachments
Patch (6.61 KB, patch)
2012-09-25 02:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.50 KB, patch)
2012-09-25 03:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-09-25 02:55:00 PDT
Created attachment 165566 [details] Patch
Mikhail Pozdnyakov
Comment 2 2012-09-25 03:06:59 PDT
Comment on attachment 165566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165566&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1163 > + WKRetainPtr<WKURLRef> redirectURL = response ? adoptWK(WKURLResponseCopyURL(response)) : 0; is it possible that response==0 ? dumpResponseDescriptionSuitableForTestResult(response); was already invoked before, and there is no such check in it. > Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:203 > + bool willSendRequestReturnsNullOnRedirect() { return m_willSendRequestReturnsNullOnRedirect; } const ?
Chris Dumez
Comment 3 2012-09-25 03:39:55 PDT
Comment on attachment 165566 [details] Patch Going to take Mikhail's feedback into consideration. Thanks.
Chris Dumez
Comment 4 2012-09-25 03:43:16 PDT
Created attachment 165572 [details] Patch Take Mikhail's feedback into consideration.
Mikhail Pozdnyakov
Comment 5 2012-09-25 03:46:02 PDT
Comment on attachment 165572 [details] Patch LGTM, thanks
WebKit Review Bot
Comment 6 2012-09-25 04:23:37 PDT
Comment on attachment 165572 [details] Patch Clearing flags on attachment: 165572 Committed r129487: <http://trac.webkit.org/changeset/129487>
WebKit Review Bot
Comment 7 2012-09-25 04:23:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.