Bug 97522

Summary: [EFL][WK2] Added hideColorPicker test case
Product: WebKit Reporter: KwangYong Choi <ky0.choi>
Component: WebKit EFLAssignee: KwangYong Choi <ky0.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91832    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

KwangYong Choi
Reported 2012-09-24 21:48:10 PDT
Added a test case for removing input element during color picker is shown. Multiple color picket case is not happened because WebCore supports only one color picker. There is no action when another input element is clicked during a color picker is exist.
Attachments
Patch (4.72 KB, patch)
2012-09-25 01:59 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.01 KB, patch)
2012-09-25 02:32 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
KwangYong Choi
Comment 1 2012-09-25 01:59:33 PDT
Created attachment 165560 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-09-25 02:03:08 PDT
Comment on attachment 165560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165560&action=review the numbers confuse me. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:693 > + // 5. Test color picker is shown. > + // 9. input_picker_color_dismiss() is called if the element is removed. 5. then 9? So this function is called twise? Cant we use different functions?
KwangYong Choi
Comment 3 2012-09-25 02:10:35 PDT
(In reply to comment #2) > (From update of attachment 165560 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165560&action=review > > the numbers confuse me. > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:693 > > + // 5. Test color picker is shown. > > + // 9. input_picker_color_dismiss() is called if the element is removed. > > 5. then 9? So this function is called twise? Cant we use different functions? Yes, it's called twice. I will make it different functions.
KwangYong Choi
Comment 4 2012-09-25 02:32:23 PDT
Created attachment 165562 [details] Patch
WebKit Review Bot
Comment 5 2012-09-25 05:19:03 PDT
Comment on attachment 165562 [details] Patch Clearing flags on attachment: 165562 Committed r129490: <http://trac.webkit.org/changeset/129490>
WebKit Review Bot
Comment 6 2012-09-25 05:19:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.