Bug 97475

Summary: Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, morrita, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96804    
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2012-09-24 12:31:29 PDT
Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
Attachments
Patch (3.57 KB, patch)
2012-09-24 13:11 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2012-09-24 13:26 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-09-24 13:11:57 PDT
Created attachment 165434 [details] Patch
Ojan Vafai
Comment 2 2012-09-24 13:21:31 PDT
Comment on attachment 165434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165434&action=review > Source/WebCore/rendering/RenderMeter.cpp:71 > + LayoutRect frame = frameRect(); > + if (isHorizontalWritingMode()) > + frame.setHeight(computedValues.m_extent); > + else > + frame.setWidth(computedValues.m_extent); Dead code?
Tony Chang
Comment 3 2012-09-24 13:26:14 PDT
Created attachment 165436 [details] Patch
Tony Chang
Comment 4 2012-09-24 13:26:39 PDT
Comment on attachment 165434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165434&action=review >> Source/WebCore/rendering/RenderMeter.cpp:71 >> + frame.setWidth(computedValues.m_extent); > > Dead code? Oops, fixed the code below it to use |frame|.
WebKit Review Bot
Comment 5 2012-09-24 14:11:29 PDT
Comment on attachment 165436 [details] Patch Clearing flags on attachment: 165436 Committed r129409: <http://trac.webkit.org/changeset/129409>
WebKit Review Bot
Comment 6 2012-09-24 14:11:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.