Bug 97453

Summary: Web Inspector: ResourceScriptMapping should no steal scripts from other mappings.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-09-24 07:14:45 PDT
Patch to follow.
Attachments
Patch (10.62 KB, patch)
2012-09-24 07:17 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (9.51 KB, patch)
2012-09-25 00:32 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-09-24 07:17:09 PDT
Created attachment 165376 [details] Patch
Pavel Feldman
Comment 2 2012-09-24 09:43:00 PDT
Comment on attachment 165376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165376&action=review > Source/WebCore/inspector/front-end/Script.js:186 > + return this._sourceMapping; I would rather store mapping's scripts in its instance.
Vsevolod Vlasov
Comment 3 2012-09-25 00:32:15 PDT
Created attachment 165540 [details] Patch
Pavel Feldman
Comment 4 2012-09-25 02:27:13 PDT
Comment on attachment 165540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165540&action=review > Source/WebCore/inspector/front-end/ResourceScriptMapping.js:83 > + this._scripts.push(script); I don't think you want anonymous scripts here.
Vsevolod Vlasov
Comment 5 2012-09-25 03:58:37 PDT
Committed r129485: <http://trac.webkit.org/changeset/129485>
Note You need to log in before you can comment on or make changes to this bug.