Bug 97431

Summary: [EFL][WK2] Add callback functions for WKPageFindClient
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, haraken, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
none
Patch none

Jinwoo Song
Reported 2012-09-24 00:26:46 PDT
Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.
Attachments
patch (3.00 KB, patch)
2012-09-24 00:31 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (6.29 KB, patch)
2012-09-25 19:33 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-09-24 00:31:22 PDT
Created attachment 165321 [details] patch
Chris Dumez
Comment 2 2012-09-24 08:29:10 PDT
Comment on attachment 165321 [details] patch Can we unit test this?
Jinwoo Song
Comment 3 2012-09-24 21:21:43 PDT
(In reply to comment #2) > (From update of attachment 165321 [details]) > Can we unit test this? Sure, we can make a unit test. I'll add the unit test and upload a new patch.
Gyuyoung Kim
Comment 4 2012-09-24 21:28:38 PDT
Comment on attachment 165321 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=165321&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:42 > +static void didFailToFindString(WKPageRef, WKStringRef /*string*/, const void* clientInfo) It looks we can remove /*string*/. string doesn't represent anything. > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:47 > +static void didCountStringMatches(WKPageRef, WKStringRef /*string*/, unsigned matchCount, const void* clientInfo) ditto.
Jinwoo Song
Comment 5 2012-09-25 01:14:12 PDT
(In reply to comment #4) > (From update of attachment 165321 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165321&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:42 > > +static void didFailToFindString(WKPageRef, WKStringRef /*string*/, const void* clientInfo) > > It looks we can remove /*string*/. string doesn't represent anything. > Absolutely right! > > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:47 > > +static void didCountStringMatches(WKPageRef, WKStringRef /*string*/, unsigned matchCount, const void* clientInfo) > > ditto.
Jinwoo Song
Comment 6 2012-09-25 19:33:43 PDT
Created attachment 165719 [details] Patch
Jinwoo Song
Comment 7 2012-09-25 19:36:05 PDT
The unit test for didFindString() and didFailToFindString() have beend added. But the unit test for didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet. So I'll make that API and unit test in another patch.
Chris Dumez
Comment 8 2012-09-26 00:13:30 PDT
Comment on attachment 165719 [details] Patch Looks sane.
Laszlo Gombos
Comment 9 2012-09-26 20:04:41 PDT
Comment on attachment 165719 [details] Patch lgtm, r=me.
WebKit Review Bot
Comment 10 2012-09-26 20:11:18 PDT
Comment on attachment 165719 [details] Patch Rejecting attachment 165719 [details] from review queue. laszlo.gombos@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Gyuyoung Kim
Comment 11 2012-09-26 20:12:10 PDT
Comment on attachment 165719 [details] Patch Clear cq+ because Gombos reviews has problem.
Laszlo Gombos
Comment 12 2012-09-27 05:54:58 PDT
Comment on attachment 165719 [details] Patch r=me
WebKit Review Bot
Comment 13 2012-09-27 05:59:55 PDT
Comment on attachment 165719 [details] Patch Clearing flags on attachment: 165719 Committed r129758: <http://trac.webkit.org/changeset/129758>
WebKit Review Bot
Comment 14 2012-09-27 06:00:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.