Bug 97400

Summary:

Implement OES_element_index_uint / WEBKIT_OES_element_index_uint

Product:

WebKit

Reporter:

rmnoon

Component:

WebGL

Assignee:

Brandon Jones <bajones>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

abarth, abecsi, bajones, dglazkov, dino, gyuyoung.kim, haraken, japhet, kbr, noam, ojan, rakuco, vestbo, webkit.review.bot

Priority:

Version:

420+

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

rmnoon

Reported 2012-09-22 15:54:14 PDT

Out of the box, OpenGL ES 2 lacks the ability to use index buffers to index into VBOs with more than 2^16 elements (see http://www.khronos.org/opengles/sdk/docs/man/xhtml/glDrawElements.xml). The extension OES_element_index_uint adds support for using unsigned integers, thereby supporting VBOs with 2^32 elements. This is an important extension and is supported on desktop-class hardware and was added to iOS 5. The WebGL spec is here: http://www.khronos.org/registry/webgl/extensions/OES_element_index_uint/ The specification has been upgraded to Draft status, and thus may now be implemented by browsers under vendor-specific names. The name for this extension in WebKit is WEBKIT_OES_element_index_uint.

Attachments
Patch (58.83 KB, patch) 2012-10-12 15:45 PDT, Brandon Jones	no flags	Details Formatted Diff Diff
Patch (58.84 KB, patch) 2012-10-12 16:24 PDT, Brandon Jones	no flags	Details Formatted Diff Diff
Patch (60.37 KB, patch) 2012-10-15 11:07 PDT, Brandon Jones	no flags	Details Formatted Diff Diff
Patch (60.37 KB, patch) 2012-10-16 10:59 PDT, Brandon Jones	no flags	Details Formatted Diff Diff
Patch (60.35 KB, patch) 2012-10-18 09:59 PDT, Brandon Jones	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Brandon Jones

Comment 1 2012-10-12 15:45:53 PDT

Created attachment 168500 [details] Patch

Brandon Jones

Comment 2 2012-10-12 16:24:57 PDT

Created attachment 168508 [details] Patch

Build Bot

Comment 3 2012-10-12 19:58:08 PDT

Comment on attachment 168508 [details] Patch Attachment 168508 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14288125 New failing tests: fast/canvas/webgl/oes-element-index-uint.html

WebKit Review Bot

Comment 4 2012-10-13 02:38:46 PDT

Comment on attachment 168508 [details] Patch Attachment 168508 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14286171 New failing tests: platform/chromium/virtual/gpu/fast/canvas/webgl/oes-element-index-uint.html fast/canvas/webgl/oes-element-index-uint.html

Brandon Jones

Comment 5 2012-10-15 11:07:31 PDT

Created attachment 168742 [details] Patch

Brandon Jones

Comment 6 2012-10-16 10:59:35 PDT

Created attachment 168976 [details] Patch

Brandon Jones

Comment 7 2012-10-18 09:59:59 PDT

Created attachment 169429 [details] Patch

Kenneth Russell

Comment 8 2012-10-18 10:54:24 PDT

Comment on attachment 169429 [details] Patch Looks good. Nice work on the tests in particular. We should consider refactoring them as was done for conformance/textures/tex-image-and-sub-image-2d-with-canvas.html and related tests in order to reduce duplication. r=me

WebKit Review Bot

Comment 9 2012-10-18 11:18:42 PDT

Comment on attachment 169429 [details] Patch Clearing flags on attachment: 169429 Committed r131780: <http://trac.webkit.org/changeset/131780>

WebKit Review Bot

Comment 10 2012-10-18 11:18:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.