Bug 97379

Summary: Update SVGFontData for 8 bit TextRun changes
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: Layout and RenderingAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, fmalita, pdr, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2012-09-21 16:29:58 PDT
Make SVGFontData aware of 8 bit changes to TextRun.
Attachments
Patch (2.05 KB, patch)
2012-09-23 22:08 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-09-23 22:08:14 PDT
Created attachment 165310 [details] Patch
Sam Weinig
Comment 2 2012-09-25 00:54:18 PDT
Comment on attachment 165310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165310&action=review > Source/WebCore/svg/SVGFontData.cpp:148 > remainingTextInRun = createStringWithMirroredCharacters(remainingTextInRun.characters(), remainingTextInRun.length()); Is this line also 8 / 16 bit aware?
Michael Saboff
Comment 3 2012-09-25 09:43:28 PDT
(In reply to comment #2) > (From update of attachment 165310 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165310&action=review > > > Source/WebCore/svg/SVGFontData.cpp:148 > > remainingTextInRun = createStringWithMirroredCharacters(remainingTextInRun.characters(), remainingTextInRun.length()); > > Is this line also 8 / 16 bit aware? Yes, characters() up converts 8 bit data if necessary.
Geoffrey Garen
Comment 4 2012-09-25 23:32:53 PDT
Comment on attachment 165310 [details] Patch r=me
Michael Saboff
Comment 5 2012-09-26 10:43:42 PDT
Committed r129668: <http://trac.webkit.org/changeset/129668>
Note You need to log in before you can comment on or make changes to this bug.