Bug 97378 – Update ComplexTextController for 8 bit TextRun changes

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Michael Saboff]

Update ComplexTextController so that it works with 8 bit TextRun's.  It will need to up convert an 8 bit TextRun to 16 bit data unless we go through some major refactoring of the complex path.

[Michael Saboff]

Created attachment 165227 [details]
Patch

[Geoffrey Garen]

Comment on attachment 165227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165227&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:299
> +        String stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length());

Why did you choose not to call m_run.characters() here?

[Michael Saboff]

(In reply to comment #2)
> (From update of attachment 165227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165227&action=review
> 
> > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:299
> > +        String stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length());
> 
> Why did you choose not to call m_run.characters() here?

m_run is a TextRun and TextRun doesn't have a characters() method.  TextRun stores data in a union of LChar* / UChar* pointers and not a String.

[Geoffrey Garen]

Comment on attachment 165227 [details]
Patch

r=me

[Michael Saboff]

Committed r129664: <http://trac.webkit.org/changeset/129664>